QR Component using Next.js, TypeScript and Material UI

Community feedback

• 

  Abdul Khaliq 🚀•72,360

  @0xabdulkhaliqPosted almost 2 years ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  QR iMAGE ALT TEXT 📸:

  • The QR Code Component involves scanning the QR code, the image is not a decoration, so it must have an alt attribute which should explain the purpose of the image.

  ---

  • The alt with QR Code is not even explaining for what the QR image need to be used.

  ---

  • So update the alt with meaningful text which explains like QR code to frontendmentor.io

  ---

  • Example: <img src="/images/image-qr-code.png" alt="QR code to frontendmentor.io">

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  0
• 

  JuvoGenesis👾•2,010

  @AkoToSiJeromeEhPosted almost 2 years ago

  Hi! Great work out there! I noticed that the component is not aligned with the body on a 1440px screen size or dimension. So, I made a few modifications to the body properties and added some CSS (the bold text is what I modified in your source code). That's all, and I hope this works and helps. Happy coding!

  body {

  margin: 0;

  color: rgba(0, 0, 0, 0.87);

  font-family: '__Outfit_316ab5','__Outfit_Fallback_316ab5',Helvetica,Arial,sans-serif;

  font-weight: 400;

  font-size: 1rem;

  line-height: 1.5;

  vector-effect: non-scaling-stroke;

  height: 100vh;

  display: flex;

  align-items: center;

  justify-content: center;

  background-color: #fff;

  }

  Marked as helpful

  0