@Kein-Internet
Posted
It is good that you followed the design specs and your HTML semantics are very reasonable.
A few suggestions for your CSS code:
-
You can remove the
width: 100vw
and themargin: auto
you have already centered the card the flex stuff in your.container
class. -
For accessibilty reasons, it is necessary to always use
rem
instead ofpx
when adjusting the font-size. A visually impaired user might want to increase their deafult font-size in their settings and rem makes sure that the font size corresponds to thier change. Pixels does not do this making it an accessibilty concern. -
It is more safer to use
max-width
instead ofwidth
for your.container
class, using width can cause overflow of content on smaller screens (although testing your website, I don't see this problem). By using max-width, you can choose a the width you want your container to be, while also ensuring that it will shrink on smaller screens.
Keep it up!