QR Component using HTML/CSS only

Community feedback

• 

  imad•3,330

  @imadvvPosted over 1 year ago

  Greeting Ross Porter!! Congratulations for completing your first challenge, 👏👏👏.

  you did great job using flex, you can just use max-width instead to fix width on the card, and also it's a good idea to use rem instead of percentage, something like so

  .card {
  	
  max-width: 19rem;
  	
  }
  

  Overall good attempt, keep it up, and have a good day/night

  Marked as helpful

  1

  ---

  

  Ross Porter•10

  @porter-s-rossPosted over 1 year ago

  Thanks so much! I didn't think of using the fix-width, but that's a good tip. @imadbg01

  1

  

  imad•3,330

  @imadvvPosted over 1 year ago

  You're welcome friend! @porter-s-ross,

  0
• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  HEADINGS ⚠️:

  • This solution consists incorrect usage of <h3> so it can cause severe accessibility errors due to incorrect usage of level-three headings <h3>

  ---

  • Every site must want only one h1 element identifying and describing the main content of the page.

  ---

  • An h1 heading provides an important navigation point for users of assistive technologies, allowing them to easily find the main content of the page.

  ---

  • In this solution there's <h3> element which is this <h3>Improve your...</h3>, you can preferably use <h1> instead of <h3>. Remember <h1> provides an important navigation point for users of assistive technologies so we want to use it wisely

  ---

  • So we want to add a level-one heading to improve accessibility

  ---

  • Example: <h1>Improve your front-end skills by building projects</h1>

  ---

  • If you have any questions or need further clarification, and feel free to reach out to me.

  ---

  • If you have any questions or need further clarification, you can always check out my submission and/or feel free to reach out to me.

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  0

  ---

  

  Ross Porter•10

  @porter-s-rossPosted over 1 year ago

  @0xAbdulKhalid Thanks for point this out Abdul! I wasn't entirely aware of the importance of using at least one H1 element, so I appreciate your response. I will fix that and keep that in mind going forward.

  0