qr component using html and css

Community feedback

• 

  MaximilianoDanielGarcia•2,000

  @MaximilianoDanielGarciaPosted 12 months ago

  Hi Tamara, great job!

  If you are wondering how to center it, I recommend to use CSS Grid. Just add this:

  body {
      display: grid;
      place-items: center;
      min-height: 100vh;
  }
  

  Also, I noticed that your component becomes wide on larger screen sizes, to fix that, you can use max-width property, which limit its growth. For this case, I think that max-width: 250px; on your .container class it would be right.

  Finally, for your attribution part, consider this:

  .attribution {
      position: absolute;
      bottom: 25px;
  }
  

  After you apply these suggestions It will looks perfect.

  Marked as helpful

  0

  ---

  

  Tamara Bartley•50

  @emmeceePosted 12 months ago

  @MaximilianoDanielGarcia

  Thank you so much I really really appreciate the feedback. Im going to try these suggestions and resubmit to Git.

  0