Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

qr component using html and css

@emmecee

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

@MaximilianoDanielGarcia

Posted

Hi Tamara, great job!

If you are wondering how to center it, I recommend to use CSS Grid. Just add this:

body {
    display: grid;
    place-items: center;
    min-height: 100vh;
}

Also, I noticed that your component becomes wide on larger screen sizes, to fix that, you can use max-width property, which limit its growth. For this case, I think that max-width: 250px; on your .container class it would be right.

Finally, for your attribution part, consider this:

.attribution {
    position: absolute;
    bottom: 25px;
}

After you apply these suggestions It will looks perfect.

Marked as helpful

0

@emmecee

Posted

@MaximilianoDanielGarcia

Thank you so much I really really appreciate the feedback. Im going to try these suggestions and resubmit to Git.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord