Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Qr Component using HTML and CSS

@SharmarkeAhmed12

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


What are the best code practices that I should adopt in my codes. How can I increase my level of competence in regards to designing UI and implementing my designs using different frameworks. Which framework should I learn in order to further my skills.

Community feedback

@Ratified

Posted

Great work on completing your first project. However, there's something I noticed, when specifying the custom variables at the root, you made a mistake. Each of the colors should have a unique name, and the variables should also have no spacing between them.

Something like this:

:root {
    --white-color: hsl(0, 0%, 100%);
    --lightgray-color: hsl(212, 45%, 89%);
    --blue-color: hsl(220, 15%, 55%);
    --darkblue-color: hsl(218, 44%, 22%);
}

And then when using the variable in the elements, you should implement it like this:

body {
    color: var(--white-color);
    background-color: var(--lightgray-color);
}

You also made a typo on fontface, that's why the fonts aren't showing up:

@font-face {
    font-family: "Outfit";
    font-style: normal;
    font-weight: 400;
    font-display: swap;
}

@font-face {
    font-family: "Outfit";
    font-style: normal;
    font-weight: 700;
    font-display: swap;
}

Generally good work. Best of luck in you other projects.

Marked as helpful

2

@Marley-Semende

Posted

Hi @SharmarkeAhmed12. Nice work. Adding a border radius to your QR image will make it look as much closer to the original design.

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord