Design comparison
Solution retrospective
Fixed the previous solution by centering the component.
Community feedback
- @correlucasPosted over 2 years ago
Hello Daniel Grecs, congratulations for your challenge solution.
I saw thst you've published other attempt for this challenge. I want to give you an advice since I did the same thing, uploaded multiple solutions for the same challenge. Note that you can update the challenge instead of posting a new one, this way you keep concentrated all feedbacks in the same solution, is also better to have one solution for each challenge to keep your challenge feed clean and also for hiring purposes since your solution gallery is like your portfolio.
About your solution you can consider using *rem instead of pixels to have a better performance between multiple screens sizes, since rem is a relative unit for sizes and pixel ins kinda fixed.
I hope this feedback help you in some way bro, keep coding, I'm in the same situation you're, changing profession and trying a frontend career. Happy coding ✌️✌️
Marked as helpful1@DanielGrecPosted over 2 years ago@correlucas Thank you for all the great info!
About the solutions, yeah, I have just found out that I can update the same solution instead of creating a new one. Makes everything much easier! Will certainly try to use 'rem' more instead of 'px'.
Every feedback is a great help, no exceptions! Thanks and happy coding to you too!
1
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord