Skip to content
Submitted over 2 years ago

QR component using HTML and CSS

mnasr118•60
@mnasr118
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

I didn't realize that the component was the exact same in the desktop design files and the mobile files for a little bit. I did a little bit of extra work because of that. I am still not sure when I should be using the direct CSS suggestions from the figma files or if I should be attempting to get as close as possible using REM units. Is one better than the other? Is there a best practice out there?

Community feedback

  • talisong-cardoso•100
    @talisong-cardosoPosted over 2 years ago

    There is a bit of unnecessary code, for example, as the font-family is unique for the whole page, it could be added to the body.

    1. For accessibility reasons the use of a h1 tag is missing, the div class="header" could be changed to h1 class="header".
    2. in div class=""header-wrapper" the css properties are not having any effect.
    Marked as helpful
    0
    mnasr118•60
    @mnasr118Posted over 2 years ago

    @talisong-cardoso Hey really appreciate the feedback. Thats awesome! Thank you!

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord