Submitted about 1 month ago

QR component using HTML and CSS

Gustavo Gutiérrez• 70

@gustavo2023

Preview site(opens in new window)View code(opens in new window)

This is a solution for...

QR code component

HTML
CSS

1newbie

View challenge

Design comparison

SolutionDesign

Solution retrospective

What are you most proud of, and what would you do differently next time?

I think I did a good job structuring the HTML, however I have some doubts about using and h1 tag for the main text in the component. Maybe I could have used a different tag that fits better for that purpose.

What challenges did you encounter, and how did you overcome them?

The only thing that felt kind of challenging was aligning the text in the place I wanted, aside from that the rest wasn't difficult.

What specific areas of your project would you like help with?

I would like to receive any feedback on things I may have done wrong or things I could have done in a more efficient way. In regards to the way I positioned the elements I would like to know if there better practices that I should have implemented, or things I should change or correct. Any feedback on the use of the tags in my html would be appreciated. As for the CSS properties I used and their values I would also appreciate any feedback on improvements I can make.

Community feedback

Eman Salama• 120

@emzzz56

Posted about 1 month ago

Congratulations Gustavo for completing this challenge. you have created a super design and your code is super clean. As the next step, I suggest moving the "Challenge by" text to the footer instead of having it in the main section. also, it's a good practice to start your CSS for any project with reset CSS so your CSS doesn't look different on different browsers.

I'm looking forward to seeing more of your work. Keep up the good work :)

Marked as helpful

Gustavo Gutiérrez• 70

@gustavo2023

Posted about 1 month ago

Hi Eman, thank you for the feedback. I had no idea about starting my project with reset CSS so that was really helpful. I read that is quite common to use Eric Meyer's CSS reset so I thought about using it, but if you have any suggestions regarding that I would appreciate it. I also took note of your comment about moving the "Challenge by" text to the footer and I'm going to apply it. Hope you have a good day and once again thanks for the feedback.

Please log in to post a comment

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord