QR Component Using HTML and CSS

Community feedback

• 

  Daniil Churikov•10

  @ddosiaPosted 6 days ago

  1. the image is done through background-image of a div, instead of img tag. I see a problem with accessibility here: since in principle this is a QR code component, it shows a desired QR code of something and my guess as alt= in real world web site it would contain a description of what this QR code actually contains.
  2. Also I will relay some feedback I got from other members for the same challenge: wrapping things in divs when it isn't necessary should be avoided. I had to address this as well. Ideally the structure should be: div>img+h2+p and that's it.
  3. Paddings from figma are 16px from sides and 40 from the bottom.
  4. the font weights and family is good, but the size of the header looks smaller.

  0
• 

  Tsuna21182•80

  @Tsuna21182Posted 6 days ago

  me a gustado el tamayo de fuente

  0