QR component, using HTML & CSS

Community feedback

• 

  Rachit Patel•540

  @rachit0706Posted about 2 years ago

  Congratulations for completing your first challenge!! There are few suggestions for improving your code:

  1. Wrap the whole content inside a main tag for better semantics.
  2. You can use flexbox with flex direction as column on your main tag to center the qr component in the page. Here are some helpful resources: https://css-tricks.com/snippets/css/a-guide-to-flexbox/, https://www.w3schools.com/css/css3_flexbox.asp https://flexbox.tech/
  3. Using flexbox in the card will also fix your layout issue and then you will not need to set position attributes in the card.
  4. You can set font family in the body selector itself instead of repeatedly setting in sentence 1 and 2.

  If you have any more doubts you can reply to this feedback.

  Marked as helpful

  1

  ---

  

  Candace Minami•10

  @CandesuPosted about 2 years ago

  @rachit0706 Thank you so much!! I learned about flex-box but with your reminder it finally clicked.

  0
• 

  Lucas 👾•104,400

  @correlucasPosted about 2 years ago

  👾Hi Candace, congratulations on your solution!👋 Welcome to the Frontend Mentor Coding Community!

  Great solution and a great start! From what I saw you’re on the right track. I’ve few suggestions for you that you can consider adding to your code:

  • Fix the component responsiveness, its not working yet and this is due the fixed width you've applied to the container. The difference between width and max-width is that the first(width) is fixed and the second(max-width) is flexible and make the element shrink when the screen starts to scale down. So if you want a responsive block element, never use width choose or min-width or max-width.
  • Add a margin of around margin: 20px to avoid the card touching the screen edges while it scales down.
  • Use relative units as rem or em instead of px to improve your performance by resizing fonts between different screens and devices. These units are better to make your website more accessible. REM does not just apply to font size, but to all sizes as well.

  Here's my solution for this challenge if you wants to see how I build it: https://www.frontendmentor.io/solutions/qr-code-component-vanilla-cs-js-darklight-mode-nS2aOYYsJR

  ✌️ I hope this helps you and happy coding!

  0