Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Request path contains unescaped characters

Submitted

QR component using HTML and CSS

PerseveranceMā€¢ 10

@PerseveranceM

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


My Question is, what could I have done better?(Please look at my code and advice me.

Community feedback

Daniel šŸ›øā€¢ 44,230

@danielmrz-dev

Posted

Hello @PerseveranceM!

Your solution looks great!

I have a couple of suggestions (about semantic HTML) for improvement:

šŸ“Œ First: Use <main> to wrap the main content instead of <div>.

Think of <div> and <span> in HTML like plain boxes or placeholders. They're handy for holding content, but they don't tell us anything about what's inside or what it's meant for on the webpage.

šŸ“Œ Second: Use <h1> for the main title instead of <h2>.

Unlike what most people think, it's not just about the size and weight of the text.

  • The <h1> to <h6> tags are used to define HTML headings.
  • <h1> defines the most important heading.
  • <h6> defines the least important heading.
  • Only use one <h1> per page - this should represent the main heading/title for the whole page. And don't skip heading levels - start with <h1>, then use <h2>, and so on.

All these tag changes may have little or any visual impact but they make your HTML code more semantic and improve SEO optimization as well as the accessibility of your project.

I hope it helps!

Other than that, great job!

0
Rawan Mohamedā€¢ 130

@rawannmmohamed

Posted

Hello , good job!

i would suggest giving the body a full height to fit the screen and give it a flex to center everything inside it .

body {

height: 100vh;
display: flex;
justify-content: center;
flex-direction: column;

}

and don't forget to add 100% height to the main-div to fit the body.

happy coding !

0

@Izukamma

Posted

making a few adjustments to the height and width of your card would help polish your solution. You also need a box-shadow for your card. but overall you did a good job.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord