Design comparison
Solution retrospective
I would like to know what could have been done better in this project, what file structure is preferable to use in similar projects and larger projects, I would also like to know what good free courses or sources I can look at to improve my knowledge in frontend development.
Community feedback
- @StroudyPosted 2 months ago
- Using a
<div>
for text lacks semantic meaning. Instead, consider a<p>
tag for paragraphs or an appropriate header tag (<h1> - <h6>
) for headings. This improves accessibility, SEO, and provides clearer structure to your content.
<div class="qr-component__title"> Improve your front-end skills by building projects </div> <div class="qr-component__description"> Scan the QR code to visit Frontend Mentor and take your coding skills to the next level </div>
-
Here
<img src="./images/image-qr-code.png" alt="">
You should have a clear and descriptivealt
text for images is important because it helps people who use screen readers understand the content, making your site more accessible. It also improves SEO, as search engines usealt
text to understand the image's context, helping your site rank better, Check this out Write helpful Alt Text to describe images, -
Using
max-width: 100%
ormin-width: 100%
is more responsive than justwidth: 100%
because they allow elements to adjust better to different screen sizes. To learn more, check out this article: responsive-meaning. -
Developers should avoid using pixels (
px
) because they are a fixed size and don't scale well on different devices. Instead, userem
orem
, which are relative units that adjust based on user settings, making your design more flexible, responsive, and accessible. For more information check out this, Why font-size must NEVER be in pixels or this video by Kevin Powell CSS em and rem explained.- Another great resource for px to rem converter.
Great job taking the time to learn! Your efforts are paying off, and I hope these insights guide you to even more success. Keep pushing forward, and remember, you’ve got this! Enjoy your coding adventures! 💪
Marked as helpful0 - Using a
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord