@correlucas
Posted
👾Hello Diaa Faris, Congratulations on completing this challenge!
You’ve done really good work here putting everything together, PERFECT SOLUTION AND AMAZING CLEAN CODE. Here's few tips to improve it:
You’ve used px
as the unit for sizes but the problem with pixels is that its not optimized for multiple devices and screens. So a good fit its to use rem
or em
that have a better performance and make your site more accessible between different screen sizes and devices. REM
and EM
does not just apply to font size, but to all sizes as well.
Save your time using a CSS RESET to remove all default settings that are annoying as the margins, paddings, decorations and optimize it making easier to work,see the article below where you can copy and paste this css code cheatsheet: https://piccalil.li/blog/a-modern-css-reset/
✌️ I hope this helps you and happy coding!
Marked as helpful