Skip to content
Submitted almost 2 years ago

qr component starter challenge

Rachel Dooley•50
@Rae1821
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Community feedback

  • Atif Iqbal•3,200
    @atif-devPosted almost 2 years ago

    Hi Rachel Dooley, congrats🎉 on completing the challenge. Better take care about following points.

    • Always check Frontendmentor Report Generator issues after submitting the project for removing errors and warnings. To avoid accessibility issue "All page content should be contained by landmarks" use code as :
    <body>
    <main>
        ---your code here----
    </main>
  <footer>
  </footer>
</body>

    (why main matters? Read here)

    • There are responsiveness issues in your solution. Now a days responsiveness matters a lot. If you don't know much about responsiveness, you can learn from FreeCodeCamp or you can check out this free short course for getting started in responsiveness.
    • When we open GitHub repository link, at right side you will find an About Section. There, also include live preview link of your project. It is better for someone to check your live project while interacting with code.

    (Have any questions🧪?reply to this comment😇)

    Hope you will find this Feedback Helpful.🙂

    0
    Rachel Dooley•50
    @Rae1821Posted almost 2 years ago

    Hi Atif, thank you so much for your feedback. I implemented the changes you suggested. Please let me know what you think.

    1
    Atif Iqbal•3,200
    @atif-devPosted almost 2 years ago

    @Rae1821 That's Nice🙂. Looking forward to review more projects from your end.

    0
  • Chermann KING•430
    @Chermann-KINGPosted almost 2 years ago

    Hey Rachel !

    Good job. The only thing I can recommend is the use of a CSS class when you feel that the selectors are so numerous that you risk confusing them all. And don't forget that it also affects accessibility

    0
    Rachel Dooley•50
    @Rae1821Posted almost 2 years ago

    Hi Chermann,

    Thank you so much for your feedback. Is there a class you would suggest to use for this project or just something I should keep in mind for larger projects down the road?

    0
    Chermann KING•430
    @Chermann-KINGPosted almost 2 years ago

    @Rae1821 In my opinion, for this project, there is no need to use classes because each of the tags you used cannot be confused by others in the page when selecting them in CSS to apply style templates. The more the project contains distinct tags, the more we could get lost in the targeting of these tags, so we use IDs or Classes to better differentiate them. It is also important to use the right tag to display a specific element and to name explicitly a class or an id to be able to find it in the proofreading of its code or by a collaborator.

    0
    Rachel Dooley•50
    @Rae1821Posted almost 2 years ago

    @Chermann-KING Ah, yes I see. I'll keep that in mind. Thanks for the feedback.

    0
    Chermann KING•430
    @Chermann-KINGPosted almost 2 years ago

    @Rae1821 My pleasure 😉

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord