QR Component Page using CSS Flex

Community feedback

• 

  Dylan de Bruijn•3,230

  @DylandeBruijnPosted 4 months ago

  @liamlizard

  Hiya! 👋

  Congratulations on your solution, it looks very close to the design! I can tell you put a lot of effort into it.

  Things you could improve ✍️

  • I suggest adding a bit of padding to your body element so the card has some space around it on smaller viewports.

  • You could add a min-height: 100vh to your body element instead of height: 100vh so it takes up the full height of the viewport while still being able to grow when the content inside it grows.

  • Try experimenting with CSS variables, they help you make your CSS values more reusable across your code.

  • Try using semantic HTML elements like main, section and article.

  • Try using using relative CSS units like rem and em they make your layout more adaptable.

  • You don't have to put width: 100vw on your html and body. These elements are block elements and take up the full width of their parent by default.

  • You don’t have to wrap your image in a separate div, it’s possible to style it directly to achieve the same result.

  • Instead of using the b element, try using something like a p tag and CSS to make your text bold.

  I hope you find my feedback helpful! 🌟

  Let me know if you have more questions and I'll do my best to answer them. 🙋‍♂️

  Happy coding! 😎

  0
• 

  P

  Aram Hekimian•410

  @HekimianzPosted 4 months ago

  If you put a height of 100vh on the body it should center it if you already put flex on it :D

  0