Design comparison
Solution retrospective
I am proud that this did not take too long and my initial ideas of how to divide the project worked well. I would look at the style guide earlier than I did.
What specific areas of your project would you like help with?Centering the main part of the project. I already used display: flex, align-items:center, justify-content: center on the parent of the main container I used to hold the QR code, so I was unable to figure it out.
Community feedback
- @DylandeBruijnPosted 3 months ago
@liamlizard
Hiya! π
Congratulations on your solution, it looks very close to the design! I can tell you put a lot of effort into it.
Things you could improve βοΈ
-
I suggest adding a bit of
padding
to yourbody
element so the card has some space around it on smaller viewports. -
You could add a
min-height: 100vh
to yourbody
element instead ofheight: 100vh
so it takes up the full height of the viewport while still being able to grow when the content inside it grows. -
Try experimenting with CSS variables, they help you make your CSS values more reusable across your code.
-
Try using semantic HTML elements like
main
,section
andarticle
. -
Try using using relative CSS units like
rem
andem
they make your layout more adaptable. -
You don't have to put
width: 100vw
on yourhtml
andbody
. These elements areblock
elements and take up the full width of their parent by default. -
You donβt have to wrap your image in a separate
div
, itβs possible to style it directly to achieve the same result. -
Instead of using the
b
element, try using something like ap
tag and CSS to make your text bold.
I hope you find my feedback helpful! π
Let me know if you have more questions and I'll do my best to answer them. πββοΈ
Happy coding! π
0 -
- @HekimianzPosted 3 months ago
If you put a height of 100vh on the body it should center it if you already put flex on it :D
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord