Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

QR component

@KIvanovvv

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Any feedback would be much appreciated . Thank you for your time !

Community feedback

Adriano 34,090

@AdrianoEscarabote

Posted

Hi Krasimir Ivanov, how are you?

I really liked the result of your project, but I have some tips that I think you will enjoy:

  • every Html document must contain the main tag, so we can identify the main content, to fix this, wrap all the content with the main tag. HTML5 landmark elements are used to improve navigation experience on your site for users of assistive technology.
  • images must have alt text unless it is a decorative image, for any decorative image each IMG tag must have empty alt="" and add aria-hidden="true" attributes to make all the assistive technologies of the Web, as screen reader. Learn the differences between decorative/meaningless images vs important content.

The rest is great!

I hope it helps... 👍

0

@KIvanovvv

Posted

@AdrianoEscarabote Thanks for the tip I wasn't fully aware of the use of alt. I will add it on future projects. Thank you for taking of your time reviewing my code :)

1
Adriano 34,090

@AdrianoEscarabote

Posted

@KIvanovvv no problem, keep coding!!

0
Vanza Setia 27,795

@vanzasetia

Posted

Hi!

One recommendation I have is to add alternative text to the QR code. First, img element must always have alt attribute. Then, this is an important content of the page. So, it should have alternative text.

I hope this helps! Happy coding!

0

@KIvanovvv

Posted

@vanzasetia Hi thanks for the feedback. I'll take a note on that.

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord