QR component

Community feedback

• 

  Adriano•38,790

  @AdrianoEscarabotePosted about 2 years ago

  Hi Krasimir Ivanov, how are you?

  I really liked the result of your project, but I have some tips that I think you will enjoy:

  • every Html document must contain the main tag, so we can identify the main content, to fix this, wrap all the content with the main tag. HTML5 landmark elements are used to improve navigation experience on your site for users of assistive technology.
  • images must have alt text unless it is a decorative image, for any decorative image each IMG tag must have empty alt="" and add aria-hidden="true" attributes to make all the assistive technologies of the Web, as screen reader. Learn the differences between decorative/meaningless images vs important content.

  The rest is great!

  I hope it helps... 👍

  0

  ---

  

  Krasimir Ivanov•40

  @KIvanovvvPosted about 2 years ago

  @AdrianoEscarabote Thanks for the tip I wasn't fully aware of the use of alt. I will add it on future projects. Thank you for taking of your time reviewing my code :)

  1

  

  Adriano•38,790

  @AdrianoEscarabotePosted about 2 years ago

  @KIvanovvv no problem, keep coding!!

  0
• 

  Vanza Setia•27,775

  @vanzasetiaPosted about 2 years ago

  Hi!

  One recommendation I have is to add alternative text to the QR code. First, img element must always have alt attribute. Then, this is an important content of the page. So, it should have alternative text.

  I hope this helps! Happy coding!

  0

  ---

  

  Krasimir Ivanov•40

  @KIvanovvvPosted about 2 years ago

  @vanzasetia Hi thanks for the feedback. I'll take a note on that.

  1