Skip to content
Submitted over 2 years ago

QR Component in which I tried keeping the CSS code at minimum

jackzorola•40
@jackzorola10
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

I'm wondering what is a best practice, for example I kept the <img>, <h1> & <p> with no classes, instead, since this is a very simple component I simply added .card and then the html tags.

Additionally on the report I get the following accessibility issues: "should be contained by landmarks", could you please explain me what does it mean by that? I have no clue on how to resolve that.

Thanks in advance!

Community feedback

  • Byron•2,290
    @byronbyronPosted over 2 years ago

    Looks good @jackzorola10

    The landmarks issue basically means you're missing a <main> tag. Try wrapping everything inside the <body> with a <main> tag.

    Hope that solves your issue 👍

    Marked as helpful
    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord