QR component

Community feedback

• 

  Ryan Barnes•250

  @barnesPosted almost 3 years ago

  Looks good. I did this one today myself, so I'm no expert but I'll provide some feedback;

  You can get rid of the margin on the card itself since it is centered with flexbox.

  I'd avoid the fixed px height of the card. It seems fine on desktop, but take a look as you shrink, you'll end up with dead space around the bottom. I think you'd be fine with no set height, letting it scale as needed.

  In terms of React, I'm no expert, but I'd try to define the component to take in all data fields, the image, title and description so it'll be reusable for any QR code you feed it.

  But overall, nice work!

  Marked as helpful

  1

  ---

  

  Manish Manwani•30

  @ManishManwani36Posted almost 3 years ago

  @barnes Yeah I figured not using a set height would be ideal, I'll keep that in mind. Also, you're right, I should have probably split up the component more. Just need to be mindful of CSS files for all the components though, I was thinking of using SCSS but at the same time debating if I should use a single CSS file or multiple component based CSS files.

  Appreciate the feedback!

  0
• 

  optimusprime202•1,200

  @optimusprime202Posted almost 3 years ago

  Hey @ManishManwani36, Now you’ve figured it out.

  0
• 

  Dev Rathore•2,600

  @GitHub-dev12345Posted almost 3 years ago

  Used this code 😊😎 for size:

  used this CSS Property in your card to increase and decrease the size of card:

  1.In Card design CSS Code Used this:

  transform : scale(0.8); this property decrease the size of card. 😉

  large size for increase the number of scale & small size for decrease the number of scale

  0