Skip to content
Submitted 9 months ago

QR Component

Diego López•40
@dialoma
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

I am really unsure about responsiveness and the css i wrote, I am actually learning html5 and css. I am not sure how I should approach css or how to get better at it

Community feedback

  • Daniel 🛸•44,310
    @danielmrz-devPosted 9 months ago

    Hello @dialoma!

    Your solution looks excellent!

    I have just one suggestion:

    • Use <main> to wrap the main content instead of <section>.

    📌 The tag <section> would make more sense if the card was part of a bigger website (in certainly would in real world), but here it is all we have on the screen.

    This tag change does not impact your project visually and makes your HTML code more semantic, improving SEO optimization as well as the accessibility of your project.

    About responsiveness, this project is not the best to practice it because the mobile and desktop version are pretty much the same. You'll have the opportunity to practice it on the next challenges.

    I hope it helps!

    Other than that, great job!

    Marked as helpful
    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord