Design comparison
Solution retrospective
Hello everyone successfully completed the this QR-Component challenge by frontend mentor please review this and comment, where I can improve my styling skills. thankyou
Community feedback
- @MelvinAguilarPosted over 1 year ago
Hello there π. Good job on completing the challenge !
I have some suggestions about your code that might interest you.
HTML π·οΈ:
- Use semantic elements such as
<main>
and<footer>
to improve accessibility and organization of your page.
- For specificity reasons you should work with classes instead of ids because they are more reusable. You can use ids to work with JavaScript, but you should use classes to style your elements. You can read more about this here π.
Alt text π·:
-
The
alt
attribute should explain the purpose of the image. Uppon scanning the QR code, the user will be redirected to the frontendmentor.io website, so a betteralt
attribute would beQR code to frontendmentor.io
If you want to learn more about the
alt
attribute, you can read this article. π.
Font π€:
-
It's recommended that you always use the font provided by the challenge's style guide.To import a font, follow the steps below:
- Go to the font's page on Google Fonts: https://fonts.google.com/specimen/Outfit.
- A sidebar will appear with a code snippet that you can use to import the font.
- Copy this code snippet and paste it into the <head> section of your HTML document.
- Now you can use the "Outfit" font in your CSS by specifying
font-family: 'Outfit', sans-serif;
.
CSS π¨:
- To center the component in the page, you should use Flexbox or Grid layout. You can read more about centering in CSS here π.
CSS Reset π:
-
You should use a CSS reset. A CSS reset is a set of CSS rules that are applied to a webpage in order to remove the default styling of different browsers.
CSS resets that are widely used:
I hope you find it useful! π Above all, the solution you submitted is great!
Happy coding!
Marked as helpful0@ayushprojectsPosted over 1 year ago@MelvinAguilar Thankyou for your comment I will try this way of styling. thanks for your advice.
0 - Use semantic elements such as
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord