Qr Component code css and html

Community feedback

• 

  Chams•160

  @Chams-satPosted over 1 year ago

  HI! Your solution looks nice though there are a couple of things you can improve which I hope will be helpful ! the first thing that your image path is wrong . you must reach to the image inside your images fille. i also suggest you to use html semantic convention, add <main class="container">, it will make it clearer. Use min-height: 100vh instead of height. Setting the height to 100vh may result in the component being cut off on smaller screens, such as a mobile phone in landscape orientation. last thing its better to put your stylesheet in a fille instead the html head .

  I hope you find it useful! 😄

  1