Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Qr Component code css and html

Brandon 30

@brandugar

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

Chams 160

@Chams-sat

Posted

HI! Your solution looks nice though there are a couple of things you can improve which I hope will be helpful ! the first thing that your image path is wrong . you must reach to the image inside your images fille. i also suggest you to use html semantic convention, add <main class="container">, it will make it clearer. Use min-height: 100vh instead of height. Setting the height to 100vh may result in the component being cut off on smaller screens, such as a mobile phone in landscape orientation. last thing its better to put your stylesheet in a fille instead the html head .

I hope you find it useful! 😄

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord