@PhoenixDev22
Posted
Hi Rafał,
Congratulation on completing this frontend mentor challenge. Your solution looks great. I have some suggestions regarding your solution, if you don't mind:
- In my opinion, the alternate text is needed on this image. The alternate text should indicate where the Qr code navigate the user : like
QR code to frontend mentor
not describes the image.
width: 330px;
an explicit width is not a good way to have responsive layout . consider usingmax-width
to the card inrem
instead .
height: 510px;
It's not recommended to set height to component, let the content of the component define the height.
- Consider using rem and em units as they are flexible, specially for font size better to use rem. If your web content font sizes are set in absolute units, such as pixels, the user will not be able to re-size the text or control the font size based on their needs. Relative units “stretch” according to the screen size and/or user’s preferred font size, and work on a large range of devices.
- Remember a css reset on every project. That will do things like set the images to display block and make all browsers display elements the same.
- Using percentages for widths, using max-width and avoiding to set heights for the components, with these things is the key to mastering responsive layouts.
Aside from these , Great job on this one.
Marked as helpful
@rafal-bedkowski
Posted
@PhoenixDev22 thank's for feedback, You have right, with that height declaration, my mistake. I think that css is much more complex that I imagine, i will focus more about the topics you are mentioned.
Thank You once more for feedback
@PhoenixDev22
Posted
@rafal-bedkowski You’re welcome and glad it was helpful. Happy coding!