Skip to content
Submitted 8 months ago

QR Component challenge solution

nitsanta•50
@nitsanta
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

What are you most proud of, and what would you do differently next time?

First HTML/CSS project i've done. Next time I will write the HTML first and the move to CSS.

What challenges did you encounter, and how did you overcome them?

I couldn't find a way to center my items, Then I remembers the flexbox approach and min-height: 100vh

What specific areas of your project would you like help with?

Used margins a lot, I wonder if it is the right approach as it doesn't seem all that clean. Also, if I could write the CSS any better and if the HTML is logically correct.

Community feedback

  • Kevin Anderson•150
    @kevincandersonPosted 8 months ago

    Great work on getting it done.

    Try looking into HTML height - something I can across during this one. With VH it always leaves more on there. Not an issue at all, just something I recently learned about.

    Code looks good from my perspective, a few repeats of code in CSS, but overall good job.

    Something to try: Maybe try getting the attribution outside of the actual project?

    Marked as helpful
    0
  • TheMissingOne•190
    @MajiddevstuffPosted 8 months ago

    Bro you could have used flexbox instead of using margin while centering the heading and other elements.

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord