Design comparison
Solution retrospective
First HTML/CSS project i've done. Next time I will write the HTML first and the move to CSS.
What challenges did you encounter, and how did you overcome them?I couldn't find a way to center my items, Then I remembers the flexbox approach and min-height: 100vh
What specific areas of your project would you like help with?Used margins a lot, I wonder if it is the right approach as it doesn't seem all that clean. Also, if I could write the CSS any better and if the HTML is logically correct.
Community feedback
- @kevincandersonPosted 7 months ago
Great work on getting it done.
Try looking into HTML height - something I can across during this one. With VH it always leaves more on there. Not an issue at all, just something I recently learned about.
Code looks good from my perspective, a few repeats of code in CSS, but overall good job.
Something to try: Maybe try getting the attribution outside of the actual project?
Marked as helpful0 - @MajiddevstuffPosted 7 months ago
Bro you could have used flexbox instead of using margin while centering the heading and other elements.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord