Submitted almost 2 years ago

QR Component Card using Flexbox

Maximiliano Torres• 120

@MaxiTRR

Preview site(opens in new window)View code(opens in new window)

This is a solution for...

QR code component

HTML
CSS

1newbie

View challenge

Design comparison

SolutionDesign

Solution retrospective

My third challenge submitted! An easy one, if you are looking to make your first challenge, i very recommend start with this one!

Community feedback

バレンタイン 😈• 64,190

@VCarames

Posted almost 2 years ago

Hey, some suggestions to improve you code:

To give you HTML code structure, you want to set up your code in the following manner (only did parent containers):

  <body>
    <main>
      <article class="card-container”>
      </article>
    </main>
  </body>

The Main Element identifies the main content of the document.

While the Article Element will serve as the card’s container, because the card represents a complete, or self-contained, section of content that is, in principle, independently reusable.

More info:

https://web.dev/learn/html/headings-and-sections/

The Alt Tag description for the QR image needs to be improved upon. Its needs to tell screen reader users what it is and where it will take them to when they scan it.
The following will reduce your code and make it responsive:

*{
    padding: 0;
    margin: 0;
    box-sizing: border-box;
}

body{
    min-height: 100vh;
    font-family: 'Outfit', sans-serif;

    display: grid;
   place-content: center ;
    background-color: var(--Light-Gray);
}



.card{
    max-width: 320px;
    padding: 15px;
     background-color: var(--White);
    border-radius: 15px;
    margin: 25px;
    box-shadow: 1px 2px 30px 1px var(--Grayis-Blue)
}



.card-img img{
    display: block;
    border-radius: 15px;
    max-width: 100%;

}

.card-text{
    padding: 25px;
    color: var(--Dark-Blue);
    text-align: center;
}

.card-text__title{
    font-size: 20px;
}

.card-text__details{
    color: var(--Grayis-Blue);
}

Happy Coding! 👻🎃

Marked as helpful

Lucas 👾• 104,420

@correlucas

Posted almost 2 years ago

👾Hello @MaxiTRR, Congratulations on completing this challenge!

Great code and great solution! I’ve few suggestions for you that you can consider adding to your code:

Your solution is great and the code is working, but the HTML structure can be reduced by removing unnecessary divs, all you need is a single <main> or <div> to keep all the content inside, and nothing more. The ideal structure is the div and only the image, heading, and paragraph.

Here’s one example to show can be cleaner this HTML structure:

<body>
<main>
<img src="./images/image-qr-code.png" alt="QR Code Frontend Mentor" >
 <h1>Improve your front-end skills by building projects</h1>
<p>Scan the QR code to visit Frontend Mentor and take your coding skills to the next level</p>
</main>
</body>

To reduce the CSS you can use the direct selector for each element instead of using class this way you have a code even cleaner, for example, you can select everything using the direct selector for (img, h1, and p, main).

✌️ I hope this helps you and happy coding!

Marked as helpful

バレンタイン 😈• 64,190

@VCarames

Posted almost 2 years ago

@correlucas

"To reduce the CSS you can use the direct selector for each element instead of using class this way you have a code even cleaner, for example, you can select everything using the direct selector for (img, h1, and p, main)."

This is considered bad practice and employers will not like this method of styling.

Please log in to post a comment

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord