QR component card using CSS Flexbox and Grid

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  COMPONENT MEASUREMENTS 📐:

  • The width: 100vw property for .main element is not necessary. because div is a block level element which will take the full width of the page by default.

  ---

  • Use min-height: 100vh for .main instead of height: 100vh. Setting the height: 100vh may result in the component being cut off on smaller screens.

  ---

  • For example; if we set height: 100vh then the .main will have 100vh height no matter what. Even if the content spans more than 100vh.

  ---

  • But if we set min-height: 100vh then the .main will start at 100vh, if the content pushes the .main beyond 100vh it will continue growing. However if you have content that takes less than 100vh it will still take 100vh in space.

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  1

  ---

  

  Toluwalase•160

  @Tolux001Posted over 1 year ago

  @0xAbdulKhalid

  Thank you for using your precious time to comment on where I needed to adjust I would try and work on this properties and be better at it Much love 001✌️❤️

  0

  

  Toluwalase•160

  @Tolux001Posted over 1 year ago

  @0xAbdulKhalid Please if it possible can you explain why I am getting this accessibility report of document should have one main landmark(I read the article and I don't understand a thing explained) And if you can do a quick explanation on the three🙏🙏 Thanks Love 001✌️💙

  0

  

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  @Tolux001

  SUGGESTION 💡:

  • The accessibility error report, "Document should have one main landmark" is due to non-semantic markup, which causes lacking of landmark for a webpage

  ---

  • We can fix it by replacing the wrapper <div> element with the semantic element <main> in your index.html file to improve accessibility and organization of your page.

  ---

  • What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>. They are use to provide a more precise detail of the structure of our webpage to the browser or screen readers

  ---

  • For example:
    • The <main> element should include all content directly related to the page's main idea, so there should only be one per page
    • The <footer> typically contains information about the author of the section, copyright data or links to related documents.

  ---

  .

  I hope you find this valuable feedback helpful ! 🤠

  Marked as helpful

  1

  

  Toluwalase•160

  @Tolux001Posted over 1 year ago

  @0xAbdulKhalid Really appreciate you for the time spent in breaking this down sir I really appreciate 🙇 I will work towards it. 001✌️💙

  0