Design comparison
Solution retrospective
Hello everyone :) I would like to share with you my solution to the QR code component challenge from Frontend Mentor. It is a simple yet elegant QR code component that I built using SASS and Flexbox. I used SASS to write cleaner and more modular code, and Flexbox to create the layout. I hope you like it and I appreciate any feedback you may have. Thank you for your time and attention.
Community feedback
- @kimodev1990Posted 12 months ago
You would like to use height : 100 vh in the body element to center your design in the middle of your viewport, Other than that nice work.
Marked as helpful3@HosseinHeydarpourPosted 12 months ago@kimodev1990 Thank you so much for your feedback. added to my code ❤️
0 - @ahmedafsaPosted 12 months ago
Hello @HosseinHeydarpour, well done!
I'd like to offer a couple of suggestions:
- I noticed there's a stray end
styletag in your HTML code that might need attention. - Consider enhancing accessibility by integrating Semantic Elements such as
<main>, <section>, or <article>into your code.
Besides these minor points, your work looks excellent!
Marked as helpful2@HosseinHeydarpourPosted 12 months ago@ahmedafsa Thank you for your nice feedback. Yes right i see it now this is from the internal CSS for footer from the original index.html file. I will defiantly use more semantic elemts in fututre challenges. Thanks for your feedback 👍🏻
1 - I noticed there's a stray end
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord