QR Component - Basic Flexbox

Community feedback

• 

  Melvin Aguilar 🧑🏻‍💻•61,140

  @MelvinAguilarPosted about 1 year ago

  Hello there 👋. Good job on completing the challenge !

  I have some suggestions about your code that might interest you.

  CSS 🎨:

  • To vertically center your element, set a height for it. A defined height is essential for vertical centering. Additionally, you can eliminate the "margin" property in the .box element since it's redundant when using "align-items" and "justify-content" properties for horizontal and vertical centering. Try these changes:
    • Add a "min-height: 100vh" property to your "#container" selector to establish its height.
    • Remove the "margin: 15%" property from the ".box" as it's no longer necessary.

  Alt text 📷:

  • The alt attribute should not contain the words "image", "photo", or "picture", because the image tag already conveys that information.

  • The alt attribute should explain the purpose of the image. Uppon scanning the QR code, the user will be redirected to the frontendmentor.io website, so a better alt attribute would be QR code to frontendmentor.io

    If you want to learn more about the alt attribute, you can read this article. 📘.

  I hope you find it useful! 😄 Above all, the solution you submitted is great!

  Happy coding!

  Marked as helpful

  1
• 

  LUFFY-HAROLD-naruto•0

  @LUFFY-HAROLD-narutoPosted about 1 year ago

  that is very good my own is not that good

  0