QR Component

Community feedback

• 

  Cody Perry•90

  @CodyJPerryPosted almost 3 years ago

  Updated markup to fix accessibility and validator issues.

  0
• 

  De'Andre Barnett•60

  @Babray03Posted almost 3 years ago

  Hey boss, good job on this looks very close to the original, you even got the drop shadow on point. I saw your container had a width of 1440px, I was always to told to steer away from fixed values. I'm curious to why you made it a fixed value? When you are using em on your other values. Maybe try a width of 100% for your container.

  0

  ---

  

  Cody Perry•90

  @CodyJPerryPosted almost 3 years ago

  @Babray03 Hey! Thanks for the feedback! I set the fixed width on this challenge because nothing really changed with this design. Typically I set a precent based unit for my width and a max-width using px so it doesn't grow larger then it should.

  0