Skip to content
Submitted about 1 year ago

QR Component

Lauren Delmar•80
@lrdelmar
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

Added the landmarks as suggestion per previous solution results

Community feedback

  • _nehal💎•6,710
    @NehalSahu8055Posted about 1 year ago

    Hello Coder 👋.

    Congratulations on successfully completing the challenge! 🎉

    Few suggestions regarding design.

    • Don't use below code snippet to center the container as its not proper way to center the card.
    {
/*position: absolute;
top: 50%;
left: 50%;
transform: translate(-50%, -50%);*/
}

    • To properly center the card

    • USING FLEXBOX

    parent-container{
min-height: 100vh;
display: flex;
align-items: center;
justify-content: center;
}
    • Use Semantics for the proper design of your code.
    <body>
<main>... main content goes here ...</main> //no need to add role="main" as it is already a semantic element
<footer>...</footer>
wrap up `.attribtution(challenge by....)` div inside your footer.
</body>

    I hope you find this helpful.

    Happy coding😄

    2
  • Guerinik Abderrahmane•480
    @AbderrahmaneGuerinikPosted about 1 year ago

    Nice component ! You can improve your code by :

    • Using BEM methodologie for naming classes.
    • the height of section-qr equal to zéro so you should define the height of this section
    .section-qr {
   height: 100vh;
}

    *Enjoy coding ! *

    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord