_nehal💎• 6,710
@NehalSahu8055
Posted
Hello Coder 👋.
Congratulations on successfully completing the challenge! 🎉
Few suggestions regarding design.
- Don't use below code snippet to center the container as its not proper way to center the card.
{
/*position: absolute;
top: 50%;
left: 50%;
transform: translate(-50%, -50%);*/
}
-
To properly center the card
-
USING FLEXBOX
parent-container{
min-height: 100vh;
display: flex;
align-items: center;
justify-content: center;
}
- Use
Semanticsfor the proper design of your code.
<body>
<main>... main content goes here ...</main> //no need to add role="main" as it is already a semantic element
<footer>...</footer>
wrap up `.attribtution(challenge by....)` div inside your footer.
</body>
I hope you find this helpful.
Happy coding😄
1
