Skip to content
Submitted 8 months ago

QR component

Johann Maldonadoā€¢100
@Johann-Alpha
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

What are you most proud of, and what would you do differently next time?

I'm proud of having been able to complete the challenge. It was my first time doing something like this on my own, and although I know it was a simple challenge, it made me realise how much I needed to learn and how basic my knowledge is. However, I could complete it and learned a lot of things in the process. It isn't perfect work, but it made me improve and get better able to do similar work.

What challenges did you encounter, and how did you overcome them?

Vertical alignment was very challenging. I didn't want to use flexbox, grid, or any other technique on purpose. I solved it by assigning padding-top and bottom percentages by trial and error until I saw that the QR seemed to be centred. I know this approach isn't the best, but it worked.

What specific areas of your project would you like help with?

Any suggestions you can give are welcome. Improvements in the code, techniques to use, etc. I intentionally used the simplest things I knew so that I could better understand them. A good suggestion would be how to align items vertically for desktop and for mobiles, as I noticed that for some mobile sizes I had to scroll the page to see the full QR. Additionally, when the orientation of the mobile was horizontal the QR overflowed.

Community feedback

  • Daniel šŸ›øā€¢44,310
    @danielmrz-devPosted 8 months ago

    Hello, @Johann-Alpha!

    Your project is looking fantastic!

    I'd like to suggest a way to make it even better:

    • Using margin and/or padding isn't always the most effective method for centering an element.

    Here's a highly efficient approach to position an element at the center of the page both vertically and horizontally:

    šŸ“Œ Apply this CSS to the body (avoid using position or margins in order to work correctly):

    body {
    min-height: 100vh;
    display: flex; 
    justify-content: center;
    align-items: center;
}

    I hope you find this helpful!

    Keep up the excellent work!

    Marked as helpful
    1
    Johann Maldonadoā€¢100
    @Johann-AlphaPosted 8 months ago

    Great!! Thank you!! @danielmrz-dev

    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord