Design comparison
Solution retrospective
I'm proud of having been able to complete the challenge. It was my first time doing something like this on my own, and although I know it was a simple challenge, it made me realise how much I needed to learn and how basic my knowledge is. However, I could complete it and learned a lot of things in the process. It isn't perfect work, but it made me improve and get better able to do similar work.
What challenges did you encounter, and how did you overcome them?Vertical alignment was very challenging. I didn't want to use flexbox, grid, or any other technique on purpose. I solved it by assigning padding-top and bottom percentages by trial and error until I saw that the QR seemed to be centred. I know this approach isn't the best, but it worked.
What specific areas of your project would you like help with?Any suggestions you can give are welcome. Improvements in the code, techniques to use, etc. I intentionally used the simplest things I knew so that I could better understand them. A good suggestion would be how to align items vertically for desktop and for mobiles, as I noticed that for some mobile sizes I had to scroll the page to see the full QR. Additionally, when the orientation of the mobile was horizontal the QR overflowed.
Community feedback
- @danielmrz-devPosted 8 months ago
Hey @Johann-Alpha!
Your solution is really impressive!
I've got a couple of ideas (about how to use HTML better) that could make it even stronger:
š First: Think about using
<main>to wrap your main content instead of<div>.Imagine
<div>and<span>in HTML as basic containers. They're good for holding stuff, but they don't tell us much about what's inside or its purpose on the webpage.š Second: Consider using
<h1>for your main title instead of<h2>.It's more than just text size ā it's about structuring your content effectively:
- The
<h1>to<h6>tags are used to define HTML headings. <h1>is for the most important heading.<h6>is for the least important heading.- Stick to just one
<h1>per page ā it should be the main title for the whole page. - And don't skip heading levels ā start with
<h1>, then use<h2>, and so on.
These tweaks might not change how your page looks, but they'll make your HTML code clearer and help with SEO and accessibility.
Hope that's helpful!
Keep up the great work!
Marked as helpful0@Johann-AlphaPosted 8 months ago@danielmrz-dev Thank you, I will definitely implement what you suggested. I used divs just to get it done fast, but you're totally right in what you say.
1 - The
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord