Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

QR Codes - HTML CSS

Diego 30

@dbustamanter

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


It's my first challenge here. Any feedback can help me to a better coding performance.

Updates realized: <meta charset="UTF-8">

<link rel="icon" href="favicon/favicon-32x32.png" sizes="32x32"> <meta name="viewport" content="width=device-width, initial scale=1.0">

Community feedback

Vanza Setia 27,795

@vanzasetia

Posted

Hi! 👋

It's important for a responsive website to have meta viewport tag. Otherwise, on mobile view, everything is zoomed out. Also, add meta charset to it.

It's important to know that not all browsers default to UTF-8 character encoding. So, it's best to specify it.

Make sure you make the meta charset as the first child of the head tag. The next element after the meta charset should be the meta viewport. As the spec has said that meta element with charset attribute should fit completely within the first 1024 bytes at the start of the file.

Reference: https://www.w3.org/International/questions/qa-html-encoding-declarations

After that, do the following.

  • Remove all br elements. Let lines wrap where they need to. I suggest controlling it by setting the padding on the parent element. You can't accommodate every screen size, so it's rare you'll ever need to use them.
  • The .contenedor element should only need a max-width to prevent the card from becoming too large while still allowing it to shrink if needed. For the height, let the element inside it control it.
  • Use rem for the padding instead of the percentage unit. It's going to make sure that it has the expected value. A percentage unit is a relative unit that may have a different value on each screen size.

Hope this helps.

Marked as helpful

1

Diego 30

@dbustamanter

Posted

@vanzasetia Hi!. i apreciated your comments. i've seen your challenge and it has a lot of component that i still don't know well, i'll do my best on the next challenge and take all this in consideration.

0
Vanza Setia 27,795

@vanzasetia

Posted

@dbustamanter Did you mean "your challenge" refer to my solution for this challenge? Also, what is the component that you don't know? I will try to answer your questions as best as I can. 🙂

0

@codekesh

Posted

You have done good work. It seems nice. But for code, you have to do best practices for writing code.

  1. <img src="../img/image-qr-code.png"> in this line you have miss alt attribute this is used for details, consult guidance on providing text alternatives for images.
  2. <article class="contenedor"></article> You should use <main> attribute instead of <article> You make the webpage more robust and functional no matter what screen reader technology is used.
0

Vanza Setia 27,795

@vanzasetia

Posted

@codekesh Sorry, I don't understand about using main element is going to make the webpage more robust and functional. What does it mean by "the webpage more robust and functional"?

Also, it's a main tag, not main attribute. 🙂

0

@codekesh

Posted

@vanzasetia I am sorry, my bad. You are correct, it's tag not attribute. And Ya main tag is best practice to use because when we use section or article tag we can use inside main tag.

0
Diego 30

@dbustamanter

Posted

@codekesh Hi!, thank u for the feedback. i've updated the items mentioned. i'm very grateful for the comments, they help me to learn and see the details.

0
Vanza Setia 27,795

@vanzasetia

Posted

@codekesh No, worries. 🙂

Regarding my question, I still don't get the answer. What do you mean by using the main tag, it can make the "webpage more robust and functional no matter what screen reader technology is used?" Is that going to allow the screen reader user to navigate the page using the landmark element?

For your information, I am asking this because I'm curious about it.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord