Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

QR code-component

@Codingisfun-dot

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


This was a fun challenge, I'm hoping to get more of them.

Community feedback

Bader Idrisā€¢ 2,900

@Bader-Idris

Posted

You can set the container in the middle of the screen whatever user changes it when you add these properties to it in CSS:

.container {
  position: absolute;
  top:50%;
  left: 50%;
  transform: translate(-50%, -50%);
}

the new feature is transform, it has many lovely properties you can discover, I personally love it. Hope it's useful

Marked as helpful

0
dimar hanungā€¢ 560

@dimar-hanung

Posted

Hi There! šŸ‘‹, Congratulations on completing the challenge šŸŽ‰ .

I have some interest and feedback with your code šŸ™Œ

That i like:

  1. I appreciate the similarity of your results with the design, only slight difference in scale

My Feedback:

  • I suggest you use html semantic convention, for example <div class="kontejner"> to <main class="container">, it will make it clearer, and will improve seo if you want to submit your website to google, i recomended this article: here

  • Your css naming still doesn't represent its use, for example <h3 class="tekst1">Improve your f ... can be <h3 class="title">Improve your f ...

  • Your result is not responsive enough, for fix that add this in head section

    <meta name="viewport" content="width=device-width, initial-scale=1.0" />
    

    remove this in .kontejner

    margin-left: 800px;
    margin-right: 800px;
    

    and add this in .kontejner

     max-width: 256px;
     margin: 0 auto;
    
  • you can seperate file by folder to be more structured, for example:

public/
ā”œā”€ images/
ā”‚  ā”œā”€ image-qr-code.png
ā”œā”€ styles/
ā”‚  ā”œā”€ main.css
ā”œā”€ favicon.png
index.html

anyways overall is good, nice solution, hope it useful šŸ™Œ

Marked as helpful

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord