@josh76543210
Posted
Hi @Fossll,
Congratulations on completing the challenge. Looks good!
The card is positioned nicely but I noticed that on smaller screens the footer overlaps on top of the card because of its fixed positioning. So I have one small improvement for your code to solve this issue:
Remove the fixed positioning on the footer:
.attribution {
position: fixed;
bottom: 0;
}
And replace it with sticky positioning:
.attribution {
position: sticky;
height: 2.75rem;
top: calc(100vh - 2.75rem);
}
This will improve the look of your site on smaller screens.
Hope this is helpful for you.
Happy Coding!
@Fossll
Posted
Thanks @josh76543210 , this is a really useful tip!