QR code

Community feedback

• 

  Travolgi 🍕•31,400

  @denieldenPosted almost 3 years ago

  Hi Vlad, I took some time to look at your solution and you did a great job!

  Also I have some tips for improving your code:

  • add main tag and wrap the card for Accessibility
  • To make it look as close to the design as possible set border-radius: 1rem; to container class
  • Centering a div with absolute positioning is now deprecated, it uses modern css like flexbox or grid
  • try to use flexbox to the body for center the card. Read here -> best flex guide
  • after add min-heigth: 100vh to body because Flexbox aligns to the size of the parent container

  Overall you did well :)

  Hope this help and happy coding!

  Marked as helpful

  1

  ---

  

  Vlad•60

  @VlaaadddPosted almost 3 years ago

  @denielden Thank you very much for the answer. I'm still learning programming from an online course, so all the advice i receive is welcome. I saved that guide you sent and i'll analyze it, thank you.

  1