Skip to content
Submitted about 2 years ago

QR Code

Manny Verma•230
@mverma45
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

What are you most proud of, and what would you do differently next time?

I am proud of the fact got the project centered using divs. Also used picture tags in my code.

What challenges did you encounter, and how did you overcome them?

using the correct width in the picture tags

What specific areas of your project would you like help with?

I just want to know if I used the tags correctly.

Community feedback

  • バレンタイン 😈•64,170
    @VCaramesPosted about 2 years ago

    Hey @mverma45, some suggestions to improve you code:

    • There are lot of things that need fixing. I suggest redoing the challenge and focusing on ensure that the card looks like the FEM demo. Here are few things to get you started.

    • Currently, you HTML Code has no structure. To better structure your content and make it a lot clearer, you want to implement Semantic HTML.

    Why use Semantic HTML?

    1. Accessibility: Semantic HTML makes webpages accessible for mobile devices and for people with disabilities as well. This is because screen readers and browsers are able to interpret the code better.
    2. SEO: It improves the website SEO, or Search Engine Optimization, which is the process of increasing the number of people that visit your webpage. With better SEO, search engines are better able to identify the content of your website and weight the most important content appropriately.
    3. Easy to Understand: Semantic HTML also makes the website’s source code easier to read for other web developers.

    More Info

    [https://developer.mozilla.org/en-US/docs/Learn/HTML/Introduction_to_HTML/Document_and_website_structure] (https://developer.mozilla.org/en-US/docs/Learn/HTML/Introduction_to_HTML/Document_and_website_structure)

    https://www.freecodecamp.org/news/semantic-html5-elements/

    https://dev.to/poulamic/writing-semantic-html-3436

    • Theres no need for the Picture Element, you only have one image.

    • The Alt Tag in the QR image needs a better description. It should tell the user what it is and where it leads to when it gets scanned.

    • The "Improve your front-end skills by building projects" should be wrapped in an h1 Heading.

    • Theres no need for using position:relative on this challenge.

    Happy Coding!

    0
    Manny Verma•230
    @mverma45Posted about 2 years ago

    @vcarames ok thanks 🙏 I'll try and redo it. Also how do I get the text to wrap I tried using flex-wrap: nowrap; it did not do anything also tried the wrap same.

    0
    バレンタイン 😈•64,170
    @VCaramesPosted about 2 years ago

    @mverma45 Once you get the card to be the same max-width as the fem demo, which is 320px/20rem. You'll use padding to make the text wrap.

    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord