QR CODE

Community feedback

• 

  Travolgi 🍕•31,400

  @denieldenPosted over 2 years ago

  Hi Ekomobong, great work on this challenge! 😉

  Here are a few tips for improve your code:

  • add the bg color to body
  • add main tag and wrap the card for improve the Accessibility
  • remove all unnecessary code, the less you write the better as well as being clearer: for example the div container of title
  • to make it look as close to the design as possible add border-radius: .8rem to qr image
  • remove all margin from capsule class
  • use h1 for the title of card and not a simple p
  • use flexbox to the body to center the card. Read here -> best flex guide
  • after, add min-height: 100vh to body because Flexbox aligns child items to the size of the parent container
  • instead of using px use relative units of measurement like rem -> read here

  Overall you did well 😁 Hope this help!

  Marked as helpful

  1

  ---

  

  Ekomobong Edeme•190

  @KingLyricsPosted over 2 years ago

  @denielden Thank you for the response! Will do even better next time!

  1