QR Code

Community feedback

• 

  Hassia Issah•50,650

  @HassiaiPosted almost 2 years ago

  replace <div class="bg"> with the main tag, wrap Improve your front-end skills by building projects in <h1> and Scan the QR code to visit Frontend Mentor and take your coding skills to the next level in <p> to fix the accessibility issues. click here for more on web-accessibility and semantic html

  There is no need to for <br> in the html.

  To center .bg on the page, add min-height:100vh; display: flex; align-items: center: justify-content: center; or min-height:100vh; display: grid place-items: center to the body.

  To center .bg on the page using flexbox:
  body{
  min-height: 100vh;
  display: flex;
  align-items: center;
  justify-content: center;
  }
  

  To center .bg on the page using grid:
  body{
  min-height: 100vh;
  display: grid;
  place-items: center;
  }
  

  Replace the height in .bg with a padding value for all the sides, this will prevent the content from overflowing on smaller screens and its a responsive replacement.

  For a responsive content replace the width in .bg with max-width and reduce the value for it to be equivalent to the width of the design. max-width: 320px

  give the img a max-width of 100% instead of a width and height value and a border-radius value, the rest of the styling are not needed.

  Give h1 and p the same font-size of 15px, text-align: center, the same margin-left, margin-right and margin-top values. Give p a margin bottom value.

  Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here

  Hope am helpful.

  Well done for completing this challenge. HAPPY CODING

  0