Skip to content
Submitted over 1 year ago

QR Code

shaunfroseth•60
@shaunfroseth
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

Would love to know how to make this responsive for mobile.

Community feedback

  • Atif Iqbal•3,200
    @atif-devPosted over 1 year ago

    Hi shaunfroseth, congrats🎉 on completing the challenge. Better take care about following points.

    • Always check Frontendmentor Report Generator issues after submitting the project for removing *errors and warnings. Use alt (alternate text) attribute as it is mentioned in your Accessibility Report. alt attribute is used for Screen readers technology. Why alt attribute matters? Read here. To avoid accessibility issue "All page content should be contained by landmarks" use code as :
    <body>
    <main>
        ---your code here----
    </main>
  <footer>
  </footer>
</body>

    (why main matters? Read here)

    • For centering the container(whole card) vertically and horizontally you can use following simple block of code:
    body {
    min-height: 100vh;
    display: grid;
    place-content: center;
}
    • When we open GitHub repository link, at right side you will find an About Section. There, also include live preview link of your project. It is better for someone to check your live project while interacting with code.

    Hope you will find this Feedback Helpful.

    0
  • Sayan•130
    @logansayanPosted over 1 year ago

    Hi Shaun, your design is already looking great... to make it responsive for smaller device also I would suggest not using percentage(%) values for width as you have in your code. Instead you should be using a fixed value like "rem" or "px"... so your design does not shrink when on phone devices and you can also use media queries for specific device widths...

    In short: in your container, replace 18% width with an absolute value put height to auto

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord