QR Code

Community feedback

• 

  romila•3,570

  @romila2003Posted over 2 years ago

  Hi Victor,

  Congratulations 🎉 on completing this challenge, it was a good attempt but there are some minor issues I want to address:

  1. The width of the card is quite short so you could increase the width to around 300px to 330px.
  2. The font-family for the title and paragraph are missing.
  3. The font-color for the heading is also missing.
  4. Instead of creating empty p tags, you can add paddings between the heading and the paragraph, to give it space.
  5. It is best practice to wrap your code with the correct semantics therefore the main container should be wrapped with the main tag e.g. <main class="container"></main

  Overall, great attempt and wish you the best for your future projects so keep coding 👍.

  0