@TanDevv
Posted
Hi, Quinten-14! Great work on this one! Let's talk about a few things in the accessibility report. :)
PS: There seems to be a broken link to your github code, this may be difficult for others to give you feedback as they don't have easy access to your repository.
šHTML:
- Document should have one main landmark | All page content should be contained by landmarks
After your body tag, consider adding landmarks such as, <nav>
, <main>
and <footer>
as a parent to the corresponding content you have where it makes sense. This helps keep your HTML organized and makes it accessible for users using screen-readers, so a win-win for everybody.
(For more information on what is semantic markup, you can read this article by MDN)
šØ CSS:
- Use
min-height: 100vh
instead ofheight
on your body. Setting the height to 100vh may result in your content being cut off on smaller screens, such as a mobile phone in landscape orientation or possibly a screen-size below 375px width.
I hope you find this information helpful. Above all, your solution is great, well done! š
Marked as helpful
@Quinten-14
Posted
@YorkieLT thanks a lot I will try to fix that as soon as possible. Maybe the broken link is because I put the repository on private.