QR Code With QRCode.js

Community feedback

• 

  Naveen Gumaste•10,480

  @NaveenGumastePosted over 2 years ago

  Hello Esteban Jiménez Ruiz ! Congo 👏 on completing this challenge

  Let's look at some of your issues, shall we:

  • Add Main tag after body <main class="container"></main>.

  • Always use the "alt attribute" and write what img is , and if the img is for decorative then leave it empty but always add it with alt.

  • Reduce the padding above the p tag.

  happy Coding😀

  Marked as helpful

  0

  ---

  

  Esteban Jiménez Ruiz•30

  @estebXnDKPosted over 2 years ago

  Hi @Crazimonk. I appreciate your feedback. i'm newbie in frontend and many things I do not know how they work but I will put them into practice.

  Happy coding 👨‍💻

  1
• 

  Shashree Samuel•9,260

  @shashreesamuelPosted over 2 years ago

  Hey estebXnDK, good job completing this challenge. Keep up the good work.

  Your design looks great however I think that the card paragraph needs some space from the margin top. This can be achieved using the margin-top css property.

  In terms of your accessibility issues

  • your images need an alternative description,this can be done by specifying the alt attribute in the image tag.

  • Wrap all your content between <main> tags to get rid of the other accessibility errors.

  Once you fix your accessibility errors, your validation errors should be fixed.

  I hope this helps.

  Cheers, Happy coding 👍

  Marked as helpful

  0

  ---

  

  Esteban Jiménez Ruiz•30

  @estebXnDKPosted over 2 years ago

  Hi @TheCoderGur . I appreciate your feedback. It was very useful and in the future I will pay more attention to those details.

  happy coding. 👨‍💻

  0