QR Code with mobile first

Hello 👋. Congratulation on successfully completing your first challenge 🎉 ! !

I have some recommendations regarding your code that I believe will be of great interest to you.

HTML 🏷️:

• Since this component involves scanning the QR code, the image is not a decoration. You must not use the background-image property to add the QR code image. Instead, use the <img> tag to add the image. Use the background-image property only for decorative images that do not add any information to the page.

CSS 🎨:

• Setting the font-size to 62.5% can attract compatibility issues with third-party libraries or plugins. You can read more about this with this lectures:

  • 1. Should I change the default HTML font-size to 62.5%?.
  • 2. The Surprising Truth About Pixels and Accessibility - The 62.5% trick.
  • 3. A comment on the 62.5% trick.

  Credit to grace-snow and vanzasetia.

I hope you find it useful! 😄 Above all, the solution you submitted is great!

Happy coding!

Hello there 👋. You did a good job!

I have some suggestions about your code that might interest you.

HTML 📄:

• The heading order is important in the html structure so try to always start your headings and/or titles with an <h1> tag and then you can decrease by one if you need to use more headings in your html code.

CSS🎨:

You can use grid or flexbox to center the content no matter the viewport size. Since I use grid to achieve such purpose, you can do the following:

body {
min-height: 100vh;
display: grid;
align-items: center;
justify-content: center;
}

As I said, you can use flexbox to center the content and it will work as well.

body {
min-height: 100vh;
display: flex;
align-items: center;
justify-content: center;
}

I hope you find it useful! 😁😁 Above all, the solution you submitted is great👌!

Happy <coding /> 😎!