Skip to content
Submitted over 1 year ago

QR CODE with HTML and CSS

Joy Sóuza•10
@jooysoouzaa
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Community feedback

  • Oscar Bocanegra•235
    @obocanegra-devPosted over 1 year ago

    Hello Joy! 👋

    Congratulations on completing your first challenge on Frontend Mentor! 🎉 It looks fantastic, and you have done a great job on this initial task.

    I'd like to offer you some suggestions to further enhance your work:

    Using semantic elements in HTML is a good practice. For example, instead of using a <div class="container">, you could consider using a <main> element to represent the main content of the page. This will help improve the structure and accessibility of your code.

    It would be great if you could provide a more descriptive alt attribute for the image. For instance, instead of simply "QR code," you could describe it as "QR code to Frontend Mentor website." This will provide a better understanding of the image for users who rely on screen readers.

    I noticed that in your code, you have <html lang="pt-br">, which is fine if the content is in Portuguese. However, in this case, the text is in English, so it would be more appropriate to use <html lang="en"> to indicate that the primary language of the document is English. This will help search engines and translation tools correctly interpret the content.

    Remember that font sizes should never be in pixels. It is better to use relative units such as rem or em. These units allow the font size to adjust more flexibly across different devices and zoom settings, ensuring a better user experience.

    Overall, your work is quite good, and these suggestions will help you further refine your skills. Keep it up, and don't hesitate to explore other challenges on Frontend Mentor to continue growing as a developer! 💪

    If you have any questions or need further assistance, feel free to ask! I'm here to help.

    Wishing you great success in your future projects! 🚀✨

    Best regards, Oscar

    Marked as helpful
    1
    Joy Sóuza•10
    @jooysoouzaaPosted over 1 year ago

    Hello, Oscar!! Thank you so much for the suggestions, I made the changes you suggested. Grateful for the help!!

    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord