polukarp• 190
@polukarp
Posted
Hey, Ken. Great solution overall, but I could suggest several things to upgrade:
- Add fonts that are listed in style-guide.md (it would look even better if you apply them)
- Use
aspect-ratio: 1/1;for your .qr-image container so that it is the same ratio and size as your img element. That would be important if you would want to make a scale hover effect or something like that, because your image would overflow a liitle on the bottom, so consider using aspect-ratio property for that. Here's a link if you want to learn more about it.
Marked as helpful
1
