QR code with Flexbox

Community feedback

• 

  Lucas 👾•104,340

  @correlucasPosted about 2 years ago

  👾Hi @TomasVask, congratulations on your first solution!👋 Welcome to the Frontend Mentor Coding Community!

  Great solution and a great start! From what I saw you’re on the right track. I’ve few suggestions for you that you can consider adding to your code:

  Use relative units as rem or em instead of px to improve your performance by resizing fonts between different screens and devices. These units are better to make your website more accessible. REM does not just apply to font size, but to all sizes as well.

  To maintain the card responsive use max-width instead of width this way you allow the content to be flexible. The difference between max-width and width is that width is fixed and max-width has a maximum size but can shrink to fit the content.

  Here's my solution for this challenge if you wants to see how I build it: https://www.frontendmentor.io/solutions/qr-code-component-vanilla-cs-js-darklight-mode-nS2aOYYsJR

  ✌️ I hope this helps you and happy coding!

  Marked as helpful

  0
• 

  Illyaas•700

  @Illyaas4ShowPosted about 2 years ago

  Hi tomas and welcome to the community!

  This is an amazing solution well done!

  Just one thing, All page content should be contained by landmarks, meaning your page should have one and only one footer in the page. You should wrap your attribution div in a footer tag to help screen readers navigate through your page.

  Hope this helps, happy coding :)

  Marked as helpful

  0