Skip to content
Submitted about 2 years ago

Qr code with flexbox

Miguel Aponte•30
@MiguelAponte18
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Community feedback

  • Lucas 👾•104,400
    @correlucasPosted about 2 years ago

    👾Hi Miguel, congratulations on your solution!👋 Welcome to the Frontend Mentor Coding Community!

    Great solution and a great start! From what I saw you’re on the right track. I’ve few suggestions for you that you can consider adding to your code:

    • Use <main> instead of a simple <div> this way you improve the semantics and accessibility showing which is the main block of content on this page. Remember that every page should have a <main> block and that <div> doesn't have any semantic meaning.
    • Replace the <h2> containing the main title with <h1> note that this title is the main heading for this page and every page needs one h1 to show which is the most important heading. Use the sequence h1 h2 h3 h4 h5 to show the hierarchy of your titles in the level of importance, never jump a level.
    • Add a margin of around margin: 20px to avoid the card touching the screen edges while it scales down.
    • Use relative units as rem or em instead of px to improve your performance by resizing fonts between different screens and devices. These units are better to make your website more accessible. REM does not just apply to font size, but to all sizes as well.

    Here's my solution for this challenge if you wants to see how I build it: https://www.frontendmentor.io/solutions/qr-code-component-vanilla-cs-js-darklight-mode-nS2aOYYsJR

    ✌️ I hope this helps you and happy coding!

    Marked as helpful
    0
    Miguel Aponte•30
    @MiguelAponte18Posted about 2 years ago

    @correlucas Thanks for the tips Lucas!!

    0
  • Melvin Aguilar 🧑🏻‍💻•61,140
    @MelvinAguilarPosted about 2 years ago

    Hi @MiguelAponte18 👋, good job completing this challenge, and welcome to the Frontend Mentor Community! 🎉

    Here are some suggestions you might consider:

    With semantic tags:

    <body>
   <main>
      <article class="carta">
         . . .
      </article>
   </main>
   <footer class="attribution">
      . . .
   </footer>
<body>
    • Add an h1 tag to your solution. The <h1> element is the main heading on a web page. There should only be one <h1> tag per page, and always avoid skipping heading levels; Always start from <h1>, followed by <h2>, and so on up to <h6> (<h1>,<h2>,...,<h6>). The HTML Section Heading elements (Reference)

    Solution:

    <h1>Improve your front-end skills by building projects</h1>
    • Use margin: 0.938rem or margin: 15px in the .carta selector so that it has some space when viewed on mobile devices.
    • Use max-width: 18em to .carta selector instead of width, this will make the card container a bit responsive on mobile and set the element's maximum width to 18em. Update the image selector to make responsive images.
    img {
    object-fit: fill;
    /* height: 16em; */
    /* width: 16.2em; */
    width: 100%;
    border-radius: 0.9em;
}

    I hope those tips will help you.

    Good job, and happy coding!

    Marked as helpful
    0
    Miguel Aponte•30
    @MiguelAponte18Posted about 2 years ago

    @MelvinAguilar Thanks for the tips Melvin!!

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord