QR Code with flex layout

Community feedback

• 

  jerry•300

  @realsalePosted over 2 years ago

  Yo! Aswin,

  Congrats completing this design, you properly align your component.

  And what you did is just right, this design doesn't need the use of @media query since the design is just the same in both devices.

  In addition, I guess what's need improvement is your padding it's a little bit inconsistent, adjusting components width and little tweak in border-radius in your image will gives it a better look.

  Marked as helpful

  1

  ---

  

  Aswin Harikumar•90

  @i-am-ashwinPosted over 2 years ago

  @realsale thank you jerry.

  thanks for the suggestion of using consistent padding guess i was too much caught up in the text being arranged exactly as the design and forgot that the whole container width could have been adjusted instead.

  1

  

  jerry•300

  @realsalePosted over 2 years ago

  @i-am-ashwin welcome bro,

  You're actually using equal padding but you're setting the image margin to auto, resulting in inconsistent spacing.

  Also when using max-width property don't set the width property to absolute in size and larger than the max-width it will overridden.

  And regarding to setting img dimension make sure you don't accidentally broke the aspect-ratio

  1