Qr Code with css flexbox

Community feedback

• 

  Lucas 👾•104,400

  @correlucasPosted over 2 years ago

  Hello Buci, congratulations for your new solution!

  I've look your live site and I've some considerations, overall your solution is really accurate and match the design file. There's two points you can consider changing:

  1.The QR-Code solution you found using it as a background-image was creative, I liked that you've used also object fit to keep the image inside the box. Maybe a inserting the image in the html as <img> was a better approach because if you note, when your page get narrow, I mean like width 300px the content start to go out from the container cuz the QR-Code image doesn't get smaller, if you set it as an img and put display:block the image will adapt with the card container. You can look my solution to see what I'm trying to say:

  https://www.frontendmentor.io/solutions/qr-code-component-SJkAUS-Iq

  2. Font-size you can also define a smaller font-size for the h1 and p when the screen becomes really tiny, a value around 20px for the h1 and 12px for the p should work.

  I hope it helps you, feel free to do me further questions Buci, happy coding!

  Marked as helpful

  1

  ---

  

  Buci•40

  @alphardhafizPosted over 2 years ago

  @correlucas wow it help me alot, thanks for the feedback, I'll try to fix my code

  1