Design comparison
Solution retrospective
It's been kept clean and simple.
What challenges did you encounter, and how did you overcome them?I encountered the issue with collapsing margins, and switched to using padding instead, as that was sufficient in this instance.
What specific areas of your project would you like help with?I sometimes find it hard to determine what the right text size is for the display size. Welcome any tips on where to go for advince on best practice sizing for text.
Community feedback
- @mkborisPosted 3 months ago
Nice work James, the font size for the designs can be found in the style guide file or if you have access to the figma design you can easily determine their sizes. And you should use
rem
to define font sizes. Also, It's best practice linking Google fonts directly in the HTMLhead
section rather than directly in your CSS file as it enables asynchronous downloading, improving page load times.Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord